feat: Add type hints and validation to core utility modules #103
+12
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add return type hint to get_tokenizer() - Add type hints and checkpoint validation to generate.py main() - Add parameter type hints to suppress_output() in torch/utils.py Improves IDE support and catches potential bugs early.
dkundel-openai
requested changes
Aug 12, 2025
gpt_oss/generate.py
Outdated
| def main(args: argparse.Namespace) -> None: | ||
| # Validate checkpoint path exists | ||
| checkpoint_path = Path(args.checkpoint) | ||
| if not checkpoint_path.exists(): |
There was a problem hiding this comment.
In the case of vllm this doesn't have to be a path though. Could you modify the check for this?
There was a problem hiding this comment.
@dkundel-openai thanks! vLLM now checks local files only when required...
- Only validate local file paths for torch/triton backends - Allow vllm to use model identifiers without path validation - Addresses reviewer feedback from dkundel-openai
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds type hints and validation to core utility modules for better IDE support and early bug detection.
Changes